Upgrade to underscore 1.8.3 #1734
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
There's a new version of the packager algorithm in one of the latest commits (frantic@2d4055e) that should more closely match the node_modules algorithm. It hasn't been merged yet due to the tests' not passing but once merged it may solve this issue of not being able to use your own copy of underscore. That being said it would be nice if RN used npm's semver caret in package.json so that you could use the latest compatible version of underscore by just running |
Contributor
Contributor
Author
|
Yep, it now appears to be fixed in master. Thanks! |
Contributor
|
Awesome. |
Contributor
|
@almost updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the packager doesn't allow multiple versions of libraries (see #1646) and underscore is quite a useful library that others will use it makes sense to have the latest version as the dependency I think.