-
Notifications
You must be signed in to change notification settings - Fork 25k
Update IntegrationWithExistingApps.md #16580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Make sure a recent version of react native is used by default. Otherwise an old 0.20.1 version hosted in [jcenter](https://bintray.com/bintray/jcenter/com.facebook.react%3Areact-native) might override the version included from `node_modules`.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@facebook-github-bot label Documentation Attention: @hramos Generated by 🚫 dangerJS |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Can you tell us a bit more about why such an old version may be used? If we can fix that, it'd be ideal. I don't want to have to update this doc every time we release a new version (0.49 will be considered too old at some point). |
|
If react native is added after This gradle file would install But maybe it is a bad idea to mention a specific version even if it has the greater than tag. How about changing the gradle section to this? I.e specifically mentioning jcenter in a comment and moving "..." below the npm react native repository? |
Revert version constraint and instead add note about where jcenter() goes.
|
Thanks for the contribution. The docs have moved to their own repo at facebook/react-native-website. I've applied your change over there. |
Makes sure a recent version of react native is used by specifying that at least version 0.49 should be used for Android. Otherwise an old 0.20.1 version hosted in jcenter might override the version included from
node_modules.Motivation
Ending up with an ancient version of react native might be confusing to new users trying out react native for the first time.
Test Plan
NA
Release Notes
[DOCS] [MINOR] [IntegrationWithExistingApps.md] - Make sure a
node_modulesversion of react native is used