Added option to manually set DatePickerIOS locale. #15635
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
@facebook-github-bot label Needs more information Attention: @shergin Generated by 🚫 dangerJS |
|
Hello, |
|
@Gongreg I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
@Gongreg I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
#16639 already solved this. I will just close this one then.. |
3 participants
Motivation
Sometimes there is a need to set DatePickerIOS locale manually. For that I added optional prop locale. If user pass locale prop the DatePickerIOS will use it, otherwise it will use current phone locale.
Issues: #12405, mmazzarolo/react-native-modal-datetime-picker#31
Test Plan
Added location to RNTester DatePickerIOS screen. You can type locale and it will change to that one. For checking default locale I change phone language/region to other and it used the new locale.