Skip to content

Make prospective syntax compatible #15510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaychsu wants to merge 2 commits into from
Closed

Make prospective syntax compatible #15510

jaychsu wants to merge 2 commits into from

Conversation

@jaychsu
Copy link
Contributor

@jaychsu jaychsu commented Aug 16, 2017 •
edited
Loading

Problem

Can't run RNTester app and got the error below:

image

Resolution

Make prospective syntax(trailing commas in function parameter lists and calls, supported in ES8) compatible.

Test Plan

If correct, the RNTester can be started.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 16, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 16, 2017
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 16, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@elicwhite
Copy link
Member

elicwhite commented Aug 16, 2017

Looks related to #15517 and #15513

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Aug 16, 2017
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 16, 2017

@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@elicwhite
Copy link
Member

elicwhite commented Aug 16, 2017

Thanks for contributing!

@jaychsu
Copy link
Contributor Author

jaychsu commented Aug 16, 2017

you are welcome ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elicwhite elicwhite elicwhite approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaychsu @facebook-github-bot @elicwhite