Skip to content

Conversation

@vczero
Copy link

@vczero vczero commented Jun 5, 2015

No description provided.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2015
@sahrens
Copy link
Contributor

sahrens commented Jun 13, 2015

This seems reasonable, but can you rebase and make sure tests are passing?

@sahrens sahrens self-assigned this Jun 13, 2015
@sahrens
Copy link
Contributor

sahrens commented Jun 13, 2015

@facebook-github-bot import

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/894583160580151/int_phab to review.

@sahrens
Copy link
Contributor

sahrens commented Jun 15, 2015

Can you rebase and re-record the snapshot tests to get the travis build to pass?

@vczero
Copy link
Author

vczero commented Jun 16, 2015

@sahrens Can you rebase and re-record the snapshot tests to get the travis build to pass?--this is for @facebook-github-bot? if not be, how can I do? Thank you ~

@sahrens
Copy link
Contributor

sahrens commented Jun 16, 2015

The bot can't help here - you need to re-record for any change that will affect the snapshot tests. Follow the instructions in the docs here, update your PR, and make sure your Travis build passes and then we'll merge it in:

https://github.com/facebook/react-native/blob/master/docs/Testing.md#running-tests-and-contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants