[Packager] Allow user to specify a custom transformer file #1497
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
packager/packager.js
Outdated
There was a problem hiding this comment.
This is only available on very recent node (0.12) and io.js versions. What's the supported version for the packager?
There was a problem hiding this comment.
Oh that's odd. If we have to support older version, we might add
path.resolve(transformerPath) === path.normalize(transformerPath)
There was a problem hiding this comment.
We want to support v0.10 (after all jest doesn't run on v0.12 yet). We have a package installed for this absolute-path
|
Just fix the |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@amasad done! |
|
Great! Will do pull it. It'd be nice to add some docs to that as well :) 💃 |
|
@amasad are those docs fine? |
docs/JavaScriptEnvironment.md
Outdated
There was a problem hiding this comment.
We don't really have to wait on all interpreters. We can just end the sentence at by allowing you to use new JavaScript language features.
|
Sorry for the late reply. Just a few nits on the docs |
|
@amasad updated the docs. I actually didn't write those texts, but they're changed the way you wanted now :) |
Summary: This is an edited re-submission of #1458 because I'm stupid. Closes facebook/react-native#1497 Github Author: Johannes Lumpe <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
simplify ActivityIndicator snack example
5 participants
This is an edited re-submission of #1458 because I'm stupid.