Skip to content

Conversation

@hoodsy
Copy link
Contributor

@hoodsy hoodsy commented May 12, 2015

float from left animation for Navigator.SceneConfigs
#1100

@ericvicenti
@ide

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2015
@ericvicenti
Copy link
Contributor

The code looks pretty good. Can you post a video?

@hoodsy
Copy link
Contributor Author

hoodsy commented May 12, 2015

demo: https://drive.google.com/file/d/0B9HtmABaCcR0Zi1yNkl5UDhWbzg/view

sorry for the small view. from an app I'm working on :D

vjeux pushed a commit to vjeux/react-native that referenced this pull request May 13, 2015
Summary:
float from left animation for Navigator.SceneConfigs

facebook#1100
@ericvicenti
@ide
Closes facebook#1249
Github Author: Logan Bernard <[email protected]>

@public

Test Plan: Video: https://drive.google.com/file/d/0B9HtmABaCcR0Zi1yNkl5UDhWbzg/view
@vjeux vjeux closed this in 2ed2d20 May 13, 2015
ryanlntn pushed a commit to ryanlntn/react-native that referenced this pull request Aug 9, 2022
…ester

Merge pull request facebook#1247 from rasaha91/split-rn-tester
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants