[Android] Add TimePicker modes #12384

Kerumen · 2017-02-14T16:22:58Z

Motivation

In the spirit of #10932, I added the mode option to the TimePicker Android API.
There is only one mode available for Android < 5, the spinner one.
If we are on Android >= 5 we can choose between spinner or clock. If we specify default it will use the default of the current Android version.

Test Plan

On Android < 5, whatever we choose it will be this:

On Android >= 5, with the spinner mode:

And with the clock mode, the default:

faceach · 2017-03-01T10:01:44Z

Any progress on this?

Kerumen · 2017-03-01T10:11:09Z

I merged master into my branch. Everything is ready on my side, I'm waiting for reviews / merge.

faceach · 2017-03-01T10:32:20Z

Great, waiting for this change！For me, it's crazy to use different styles for date picker and time picker~

faceach · 2017-03-01T10:35:35Z

One suggestion, could we also pass theme color to date/time picker? Then date/time picker components will have capability to change their background colors. As now they use cyan by default.

Kerumen · 2017-03-01T11:15:39Z

@faceach I can check if it's possible and propose a new PR for this.

Kerumen · 2017-04-06T09:55:57Z

I don't know why I closed this.. Missclicked I guess. I reopen.

cyprusglobe · 2017-04-10T16:59:23Z

cc / @mkonicek @ericvicenti

Kerumen · 2017-04-10T17:45:04Z

I messed up with the branches and hard pushed another PR on top of this one.. :(
Will play with git reflog tomorrow to get back my previous work.

Kerumen · 2017-04-11T12:44:48Z

PR updated and ready to be merged!

facebook-github-bot · 2017-08-05T17:02:10Z

@Kerumen I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

Kerumen · 2017-08-08T12:45:47Z

Rebased against master. @mkonicek are you a good reviewer for this PR?

eslint-bot · 2017-08-08T12:52:32Z

RNTester/js/TimePickerAndroidExample.js

          <TouchableWithoutFeedback
            onPress={this.showPicker.bind(this, 'simple', {})}>
            <Text style={styles.text}>{this.state.simpleText}</Text>
          </TouchableWithoutFeedback>


null: Parsing error: Expected corresponding JSX closing tag for

63 | {this.state.simpleText}
64 |

65 |
| ^
66 |
67 | <TouchableWithoutFeedback
68 | onPress={this.showPicker.bind(this, 'clock', {mode: 'clock'})}>

facebook-github-bot · 2017-09-07T17:02:42Z

@Kerumen I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

Kerumen · 2017-09-08T09:25:25Z

Rebased. Maybe I will have a little more chance with @satya164 ? :)

facebook-github-bot · 2017-10-08T17:03:37Z

@Kerumen I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

satya164 · 2017-10-08T17:11:51Z

ReactAndroid/src/main/java/com/facebook/react/modules/timepicker/TimePickerDialogFragment.java

-        hour,
-        minute,
-        is24hour);
+    TimePickerDialog dialog = new DismissableTimePickerDialog(


Maybe do this in the last else block to avoid unnecessarily instantiating it?

True! I change this :)

satya164 · 2017-10-08T17:13:10Z

ReactAndroid/src/main/java/com/facebook/react/modules/timepicker/TimePickerMode.java

@@ -0,0 +1,17 @@
+/**


I think better to inline this constants in the time picker module file

I wanted to stay iso with the DatePicker implementation:
https://github.com/Kerumen/react-native/blob/4e58d510958a96a6d307d7b0ba3bd8b47f70c563/ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/DatePickerMode.java

Kerumen · 2017-10-08T18:04:00Z

@satya164 I updated the PR. Tell me if inlining the constants is really necessary.
Thanks for your time!

satya164 · 2017-10-08T18:20:48Z

@facebook-github-bot shipit

facebook-github-bot

@satya164 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: In the spirit of #10932, I added the `mode` option to the `TimePicker` Android API. There is only one mode available for **Android < 5**, the `spinner` one. If we are on **Android >= 5** we can choose between `spinner` or `clock`. If we specify `default` it will use the default of the current Android version. On **Android < 5**, whatever we choose it will be this: ![screen shot 2017-02-14 at 17 05 44](https://cloud.githubusercontent.com/assets/5436545/22937805/024ec67e-f2da-11e6-8b32-a680d9bc2247.png) On **Android >= 5**, with the `spinner` mode: ![screen shot 2017-02-14 at 16 51 17](https://cloud.githubusercontent.com/assets/5436545/22937803/024e0bbc-f2da-11e6-9f4b-26102ff2eeac.png) And with the `clock` mode, the default: ![screen shot 2017-02-14 at 16 51 02](https://cloud.githubusercontent.com/assets/5436545/22937804/024e64e0-f2da-11e6-9911-4135049f4726.png) Closes facebook/react-native#12384 Differential Revision: D6006689 Pulled By: hramos fbshipit-source-id: fcd37c867c4061b9982b1687f2c10211e54df7cf

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Feb 14, 2017

Kerumen closed this Mar 21, 2017

Kerumen force-pushed the master branch from 56c05e4 to a34956f Compare March 21, 2017 15:27

Kerumen reopened this Apr 6, 2017

Kerumen force-pushed the master branch from 47cb4db to 6363880 Compare April 11, 2017 12:43

shergin added the Android label May 31, 2017

Kerumen force-pushed the master branch 2 times, most recently from 740302c to 1d6f7b2 Compare August 8, 2017 12:43

eslint-bot reviewed Aug 8, 2017

View reviewed changes

Kerumen force-pushed the master branch from 1d6f7b2 to ee33282 Compare August 8, 2017 12:55

Kerumen force-pushed the master branch from 51acbc5 to 4e58d51 Compare September 8, 2017 09:23

satya164 suggested changes Oct 8, 2017

View reviewed changes

Kerumen added 2 commits October 8, 2017 19:59

[Android] Add TimePicker modes

6e7421c

Improve code branching

3a7426d

Kerumen force-pushed the master branch from 4e58d51 to 3a7426d Compare October 8, 2017 18:00

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Oct 8, 2017

facebook-github-bot approved these changes Oct 8, 2017

View reviewed changes

facebook-github-bot closed this in 1c24440 Oct 8, 2017

sidferreira mentioned this pull request Apr 10, 2018

[Android][Question] DatePicker / TimePicker without dialog #18783

Closed

3 tasks

[Android] Add TimePicker modes #12384

[Android] Add TimePicker modes #12384

Uh oh!

Conversation

Kerumen commented Feb 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Test Plan

Uh oh!

faceach commented Mar 1, 2017

Uh oh!

Kerumen commented Mar 1, 2017

Uh oh!

faceach commented Mar 1, 2017

Uh oh!

faceach commented Mar 1, 2017

Uh oh!

Kerumen commented Mar 1, 2017

Uh oh!

Kerumen commented Apr 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyprusglobe commented Apr 10, 2017

Uh oh!

Kerumen commented Apr 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kerumen commented Apr 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Aug 5, 2017

Uh oh!

Kerumen commented Aug 8, 2017

Uh oh!

eslint-bot Aug 8, 2017

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Sep 7, 2017

Uh oh!

Kerumen commented Sep 8, 2017

Uh oh!

facebook-github-bot commented Oct 8, 2017

Uh oh!

satya164 Oct 8, 2017

Choose a reason for hiding this comment

Uh oh!

Kerumen Oct 8, 2017

Choose a reason for hiding this comment

Uh oh!

satya164 Oct 8, 2017

Choose a reason for hiding this comment

Uh oh!

Kerumen Oct 8, 2017

Choose a reason for hiding this comment

Uh oh!

Kerumen commented Oct 8, 2017

Uh oh!

satya164 commented Oct 8, 2017

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Kerumen commented Feb 14, 2017 •

edited

Loading

Kerumen commented Apr 6, 2017 •

edited

Loading

Kerumen commented Apr 10, 2017 •

edited

Loading

Kerumen commented Apr 11, 2017 •

edited

Loading