Expose StatusBar height on iOS #12041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
GH Review: accepted
Import Started
Contributor
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Member
|
I'm going to revert this:
StatusBarManager already has an async version to get this information: |
edmofro
pushed a commit
to edmofro/react-native
that referenced
this pull request
Feb 6, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 7, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Feb 8, 2017
Summary: Following the PR facebook/react-native#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook/react-native#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
normanjoyner
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Following the PR facebook#6195, this adds a `HEIGHT` constant on `StatusBar` for iOS. Combined with `statusBarFrameDidChange` and `statusBarFrameWillChange` StatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correct `keyboardVerticalOffset` value for the KeyboardAvoidingView component. Closes facebook#12041 Differential Revision: D4450924 Pulled By: hramos fbshipit-source-id: 664798260f4226140f3fa3f9222a415a305d0d78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the PR #6195, this adds a
HEIGHTconstant onStatusBarfor iOS.Combined with
statusBarFrameDidChangeandstatusBarFrameWillChangeStatusBar native events, it solves various problems with In-Call cellar bar / Location bar / others 40pt status bars, and offers a correctkeyboardVerticalOffsetvalue for the KeyboardAvoidingView component.