Skip to content

Update GettingStarted.md if user using zsh filename should be .zshrc #10432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vadimeremeev wants to merge 2 commits into from
Closed

Update GettingStarted.md if user using zsh filename should be .zshrc #10432

vadimeremeev wants to merge 2 commits into from

Conversation

@vadimeremeev
Copy link

@vadimeremeev vadimeremeev commented Oct 18, 2016

Small contribution for MacOS users:

For those users who using zsh with their Mac OS filename to place variables should be different

@vadimeremeev
if user using zsh filename should be .zshrc
d8f32f3 
For those users who using zsh with their Mac OS filename to place variables should be different
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 18, 2016

By analyzing the blame information on this pull request, we identified @hramos and @JoelMarcey to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 18, 2016
@hramos
Copy link
Contributor

hramos commented Oct 18, 2016

Curious, how many Mac users switch to zsh? I thought about adding callouts like these for other shells, but figured if you switched your shell, you would likely also know to map .bashrc to whatever your shell uses instead.

@vadimeremeev
Copy link
Author

vadimeremeev commented Oct 19, 2016

Yup, for sure can figure it out. Just that it might take extra time if developers follow guide exactly step by step.

Also on another page I notice it was explained in details:
http://facebook.github.io/react-native/releases/0.35/docs/android-building-from-source.html#point-gradle-to-your-android-sdk

@lacker
Copy link
Contributor

lacker commented Oct 25, 2016 •
edited
Loading

I agree with the sentiment and just tweaked the wording a bit. Thanks!

@lacker
Copy link
Contributor

lacker commented Oct 25, 2016

@facebook-github-bot shipit

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Oct 25, 2016
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 25, 2016

@lacker has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

DanielMSchmidt pushed a commit to DanielMSchmidt/react-native that referenced this pull request Jan 4, 2017
@DanielMSchmidt
Update GettingStarted.md if user using zsh filename should be .zshrc
4488e5e 
Summary:
Small contribution for MacOS users:

For those users who using zsh with their Mac OS filename to place variables should be different
Closes facebook#10432

Differential Revision: D4078102

Pulled By: lacker

fbshipit-source-id: 6cbfb81a472f37bfda85964e929c99b438348fd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vadimeremeev @facebook-github-bot @hramos @lacker