Update iOS run script to fix the build launch in the simulator #10393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `scheme` of the project is different from the `project name` the iOS run script does not work for the `iOS Simulator`, since to launch the app the script is looking for `..\${inferredSchemeName}` that can be different from the real scheme name that can be passed by argument.
For this sample, if the name of the project is different from the name of the scheme, this will not work, this PR will fix that issue.
```
react-native run-ios --scheme Sandbox
```
Contributor
|
By analyzing the blame information on this pull request, we identified @LearningDave and @grabbou to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
Already fixed in #10178, which has been marked for shipping |
Contributor
Author
|
@StevePotter thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
schemeof the project is different from theproject namethe iOS run script will not work for theiOS Simulator, since to launch the app the script is looking for..\${inferredSchemeName}that can be different from the real scheme name that can be passed by argument.For this sample, if the name of the project is different from the name of the scheme, this will not work, this PR will fix that issue.