Make sure xhr req header's value is String type #10222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
By analyzing the blame information on this pull request, we identified @philikon and @davidaurelio to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
leeight
commented
Oct 3, 2016
| react_native_target('java/com/facebook/react/touch:touch'), | ||
| react_native_target('java/com/facebook/react/uimanager:uimanager'), | ||
| react_native_target('java/com/facebook/react:react'), | ||
| react_native_target('java/com/facebook/react/jstasks:jstasks'), |
Contributor
Author
There was a problem hiding this comment.
Add missing deps, make scripts/run-android-local-unit-tests.sh happy
facebook-github-bot
added
the
CLA Signed
Contributor
|
@leeight updated the pull request - view changes |
facebook-github-bot
added
the
CLA Signed
Contributor
|
@leeight updated the pull request - view changes |
leeight
commented
Oct 12, 2016
| throw new Error('Request has not been opened'); | ||
| } | ||
| this._headers[header.toLowerCase()] = value; | ||
| this._headers[header.toLowerCase()] = String(value); |
Contributor
Author
There was a problem hiding this comment.
In the NetworkingModule.java, header.getString(1) was called, so the value must be String type.
facebook-github-bot
added
the
CLA Signed
Contributor
Author
facebook-github-bot
added
the
CLA Signed
Contributor
|
@leeight updated the pull request - view changes |
facebook-github-bot
added
the
CLA Signed
Contributor
|
Arguably code should not be using this but it seems worth it to get firebase files working. The dependency thing looks like it already got fixed, though, so now Circle CI is complaining that that dependency is a duplicate. Could you fix that and then I'll ship this? |
In the `NetworkingModule.java`, `header.getString(1)` was called, so the value must be String type. FIX facebook#10198
Contributor
Author
|
@lacker Done. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
Contributor
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
Import Started
Contributor
|
@lacker has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: In the `NetworkingModule.java`, `header.getString(1)` was called, so the value must be String type. FIX facebook#10198 Closes facebook#10222 Differential Revision: D4080319 Pulled By: lacker fbshipit-source-id: 85234a2bbf90e5b9e0e65ceadbfabb330b2d1322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
NetworkingModule.java,header.getString(1)wascalled, so the value must be String type.
FIX #10198