[Android] Make ReactWebView & Client protected #10105
Conversation
In order to more easily extend ReactWebViewManager logic
|
By analyzing the blame information on this pull request, we identified @sathyapriya-31 and @jvassbo to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
ghost
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @jacobp100 as a potential reviewer. Could you take a look please or cc someone with more context? |
|
CC @satya164 |
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: I'd like to make `ReactWebView` and `ReactWebViewClient` `protected` instead of `private`, inside the `ReactWebViewManager` class. The reason being that if you extend the `ReactWebViewManager` it'll be much easier to override existing logic. In my specific case I'd like to be able to override [shouldOverrideUrlLoading](https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/views/webview/ReactWebViewManager.java#L120) inside `ReactWebViewClient` and handle custom URL schemes differently. See facebook#10055. Closes facebook#10105 Differential Revision: D4168359 Pulled By: hramos fbshipit-source-id: ff6cbcf1d56536f0db0d2eea937de2cc065a09f9
2 participants
I'd like to make
ReactWebViewandReactWebViewClientprotectedinstead ofprivate, inside theReactWebViewManagerclass. The reason being that if you extend theReactWebViewManagerit'll be much easier to override existing logic.In my specific case I'd like to be able to override shouldOverrideUrlLoading inside
ReactWebViewClientand handle custom URL schemes differently. See #10055.