-
Notifications
You must be signed in to change notification settings - Fork 25k
Closed
Labels
Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.
Description
From brief chat w @vjeux we want to improve the code review workflow using labels. The labels will show the state of each PR and help contributors and reviewers be on the same page wrt the next step for each PR. I imagine the flow to mostly look like:
- Contributor submits PR. Label: [needs-review]
- Reviewer imports PR into Differential
- Reviewer has some questions but no requests for changes yet, submits comments
- Contributor responds to questions
- Reviewer posts new comments asking for changes (can Differential ping a webhook when this happens?) Label: [needs-revision]
- Contributor updates PR by updating their branch. Label: [needs-review]
- Reviewer accepts the diff and lands it through Differential
- Bot automatically creates a corresponding Git commit and pushes it to GitHub. Bot removes the label from the PR and closes it.
(@vjeux are there parts that are different that from what you have in mind?)
Metadata
Metadata
Assignees
Labels
Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.