[Packager] Ever since GA, Packager has been *really slow* for the first time.

[jaygarcia]

I only noticed this since GA. Am i alone in this?

[10:06:27] <START> request:/Examples/UIExplorer/UIExplorerApp.includeRequire.runModule.bundle?dev=true
[10:06:27] <START> find dependencies
[10:06:44] <END>   find dependencies(16238ms)
[10:06:44] <START> transform
[10:06:44] <END>   transform(476ms)
[10:06:44] <END>   request:/Examples/UIExplorer/UIExplorerApp.includeRequire.runModule.bundle?dev=true(16747ms)

[vjeux]

What is GA?

[jaygarcia]

General Availability. :)

JG

301.785.6030 :: @moduscreate

:: sent from my mobile device ::

On Mar 27, 2015, at 12:04, Christopher Chedeau notifications@github.com wrote:

What is GA?

—
Reply to this email directly or view it on GitHub.

[amasad]

One thing that has happened is I moved the packager's node_modules to the root. Making them crawlable by the packager which is probably slowing down things. This was to fix an urgent issue #225
We should make the packager a stand alone node package.

[amasad]

Actually just tried this on a couple of machines and it seems to be running ok, it's not taking more than 5 seconds. Can you try restarting your computer?

[jaygarcia]

That's my point. 5 seconds on a cold start for packager is painfully slow. It wasn't this way before :(

JG

:: sent from my mobile device ::

On Mar 27, 2015, at 13:19, Amjad Masad notifications@github.com wrote:

Actually just tried this on a couple of machines and it seems to be running ok, it's not taking more than 5 seconds. Can you try restarting your computer?

—
Reply to this email directly or view it on GitHub.

[amasad]

Yes, we should fix it.

[sahrens]

Agreed we can and should make it faster, but I'm curious: how often and for
what reasons do you do cold starts of the packager?

On Fri, Mar 27, 2015 at 10:54 AM, Amjad Masad notifications@github.com
wrote:

Yes, we should fix it.

—
Reply to this email directly or view it on GitHub
#341 (comment)
.

[jaygarcia]

Not often :). I just happened to notice it after a kernel panic (debugging core audio implementation).

This also surfaced another strange thing: while the first cold-boot request is made to the packager, hit cmd+r. That induces a second request, causing your app to render twice.

This is most noticeable in "SampleApp"

JG

301.785.6030 :: @moduscreate

:: sent from my mobile device ::

On Mar 27, 2015, at 21:57, Spencer Ahrens notifications@github.com wrote:

Agreed we can and should make it faster, but I'm curious: how often and for
what reasons do you do cold starts of the packager?

On Fri, Mar 27, 2015 at 10:54 AM, Amjad Masad notifications@github.com
wrote:

Yes, we should fix it.

—
Reply to this email directly or view it on GitHub
#341 (comment)
.

—
Reply to this email directly or view it on GitHub.

[sahrens]

I think the render twice issue has been fixed - does it still repro for you on master?

-Spencer

On Mar 28, 2015, at 5:37 AM, Jay Garcia notifications@github.com wrote:

Not often :). I just happened to notice it after a kernel panic (debugging core audio implementation).

This also surfaced another strange thing: while the first cold-boot request is made to the packager, hit cmd+r. That induces a second request, causing your app to render twice.

This is most noticeable in "SampleApp"

JG

301.785.6030 :: @moduscreate

:: sent from my mobile device ::

On Mar 27, 2015, at 21:57, Spencer Ahrens notifications@github.com wrote:

Agreed we can and should make it faster, but I'm curious: how often and for
what reasons do you do cold starts of the packager?

On Fri, Mar 27, 2015 at 10:54 AM, Amjad Masad notifications@github.com
wrote:

Yes, we should fix it.

—
Reply to this email directly or view it on GitHub
#341 (comment)
.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

[jaygarcia]

Did pull this AM and if timed right, I can make > 2 show. I also discovered if i am an ass and hammer CMD + R, I can make it cause an exception. This second case is a much lower priority ;)

[amasad]

@jaygarcia can you open another issue for the render twice?

[ide]

The packager has been really slow after setting a couple of root directories even when it's hot. When I make a small change to one file and load the bundle in my browser, it takes about 6-7 seconds.

My hypothesis is that it's scanning deep into node_modules to see if there are any Haste directives (@amasad - would you know if this is the case?). I have some big devDependencies (gulp, coffeescript, etc.) and when I rm -rf node_modules I can now load a new bundle in less than a second. Could the packager stop traversing down the file system when it sees node_modules?

[joewood]

You could try adding the dev dependency paths to the blacklist (react-native/packager/blacklist.js - sharedBlacklist). In fact, the packager could check the root package.json for devDependencies, assuming these are just tools.