Possibility to show pins on MapView (MKPointAnnotation)

[DanielMSchmidt]

Hi there,

first of all thanks for open sourcing this great library, it really made my day (and will likely make my month).
I would like to ask if there is yet a possibility to show markers / pins (MKPointAnnotation is the real name I guess) on the map? If not and if you would like, I would be glad to work an a PR for this feature.

Regards and thanks for the great work!

+1

[dbanck]

👍

[tadeuzagallo]

Hey @DanielMSchmidt, there isn't any api for that so far... but please, if you want to work on it, go ahead! :)

[DanielMSchmidt]

Great, I will do so ;)

[lloydh6]

👍

[DanielMSchmidt]

@tadeuzagallo Would this syntax be okay?

<MapView pins={this.state.pins} />

[tadeuzagallo]

It's good to me, although I'm not the best for naming... if someone is against it, it should be fairly easy to rename the property later, so I'd say go for it!

[BenHall]

@DanielMSchmidt What's the latest on this? Anything I can do to help as I need it for my app?

[DanielMSchmidt]

The current status is, that it's possible to add pins to the map, but after some seconds the map freezes. I haven't updated any documentation yet, nor written any tests. As I am (unfortunately) on vacation, I won't have time to fix this, but I could and likely will write the documentation and some tests.

I would be really happy if you would take a look at the current status and fix the freezing. My hint would be, that I simply added the annotations at the wrong time of the maps lifecycle or in a method that gets called too often. I added you as collaborator to my fork and if you need an example implementation, see here. Thanks for your help!

[DanielMSchmidt]

Update: the code is working now, I will soon add the documentation and tests and then I will open a PR

[DanielMSchmidt]

Pins seem to be implemented as annotaions while I have been working on this PR, just FYI.

[dominicthomas]

Any tips on how to change the design of the pins to incorporate say an image or a custom view?

[onchainguy-btc]

@dominicthomas did you find out how to style custom markers/pins?