App force close on release mode: undefined is not an object (evaluating 'e.length')

[brunolemos]

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: macOS High Sierra 10.13
Node: 8.9.0
Yarn: 1.2.1
npm: 5.5.1
Watchman: 4.7.0
Xcode: Xcode 9.1 Build version 9B37
Android Studio: 3.0 AI-171.4402976

Packages: (wanted => installed)
react: ^16.0.0 => 16.0.0
react-native: ^0.50.2 => 0.50.2

Target Platform: iOS (11.1)

Steps to Reproduce

1. App with React Native v0.50+ installed
2. Run debug build (works)
3. Run release build (crash on app open)

Expected Behavior

Not crash

Actual Behavior

Crash on app open with this error:
RCTFatalException: Unhandled JS Exception: undefined is not an object (evaluating 'e.length')'

Stack points inside the color-converter package.

Current workaround

• Downgrade to 0.49.5

[brunolemos]

Possibly related: #16743, #16689
Duplicated: GeekyAnts/NativeBase#1348

[brunolemos]

@petejkim @stephenheron I see you have the same problem, did you manage to fix?

[stephenheron]

Hi @brunolemos

Still having the same problem I am afraid.

It is quite tricky to track down as the error is not very helpful and it does not happen in debug mode. I thought it was a problem with NativeBase to be honest but if you are not using NativeBase then it points to something else.

Is there a way of us getting more useful crash information I wonder?

Thanks,
Stephen

[ovr]

I don't use NativeBase, but I am having similar problem, it's rly hard to debug

{"offset":{"line":690,"column":0},"map":{"version":3,"sources":["/Users/ovr/projects/interpals/mobile/node_modules/color-string/color-string.js"],"names":["__d","global","require","module","exports","getRgba","string","rgb","a","match","i","length","parseInt","slice","parseFloat","Math","round","colorNames","scale","getHsla","alpha","isNaN","getHwb","rgbaString","rgba","undefined","percentaString","hslaString","hsla","num","min","max","hexDouble","str","toString","toUpperCase","getRgb","getHsl","getAlpha","vals","hexString","rgbString","percentString","hslString","hwbString","hwb","keyword","reverseNames","name"],"mappings":"AAAAA,IAAA,SAAAC,EAAAC,EAAAC,EAAAC,GAsBA,SAASC,EAAQC,GACd,GAAKA,EAAL,CAGA,IAMIC,GAAO,EAAG,EAAG,GACbC,EAAI,EACJC,EAAQH,EAAOG,MARP,uBASZ,GAAIA,EAAO,CACRA,EAAQA,EAAM,GACd,IAASC,EAAI,EAAGA,EAAIH,EAAII,OAAQD,IAC7BH,EAAIG,GAAKE,SAASH,EAAMC,GAAKD,EAAMC,GAAI,SAGxC,GAAID,EAAQH,EAAOG,MAdb,uBAcyB,CACjCA,EAAQA,EAAM,GACd,IAASC,EAAI,EAAGA,EAAIH,EAAII,OAAQD,IAC7BH,EAAIG,GAAKE,SAASH,EAAMI,MAAU,EAAJH,EAAW,EAAJA,EAAQ,GAAI,SAGlD,GAAID,EAAQH,EAAOG,MAnBb,2FAmB0B,CAClC,IAASC,EAAI,EAAGA,EAAIH,EAAII,OAAQD,IAC7BH,EAAIG,GAAKE,SAASH,EAAMC,EAAI,IAE/BF,EAAIM,WAAWL,EAAM,SAEnB,GAAIA,EAAQH,EAAOG,MAxBd,6GAwB0B,CACjC,IAASC,EAAI,EAAGA,EAAIH,EAAII,OAAQD,IAC7BH,EAAIG,GAAKK,KAAKC,MAAiC,KAA3BF,WAAWL,EAAMC,EAAI,KAE5CF,EAAIM,WAAWL,EAAM,SAEnB,GAAIA,EAAQH,EAAOG,MA7BV,SA6B0B,CACrC,GAAgB,eAAZA,EAAM,GACP,OAAQ,EAAG,EAAG,EAAG,GAGpB,KADAF,EAAMU,EAAWR,EAAM,KAEpB,OAIN,IAAK,IAAIC,EAAI,EAAGA,EAAIH,EAAII,OAAQD,IAC7BH,EAAIG,GAAKQ,EAAMX,EAAIG,GAAI,EAAG,KAS7B,OAHGF,EAJEA,GAAU,GAALA,EAIHU,EAAMV,EAAG,EAAG,GAHZ,EAKPD,EAAI,GAAKC,EACFD,GAGV,SAASY,EAAQb,GACd,GAAKA,EAAL,CAGA,IACIG,EAAQH,EAAOG,MADT,4GAEV,GAAIA,EAAO,CACR,IAAIW,EAAQN,WAAWL,EAAM,IAK7B,OAJQS,EAAMN,SAASH,EAAM,IAAK,EAAG,KAC7BS,EAAMJ,WAAWL,EAAM,IAAK,EAAG,KAC/BS,EAAMJ,WAAWL,EAAM,IAAK,EAAG,KAC/BS,EAAMG,MAAMD,GAAS,EAAIA,EAAO,EAAG,MAKjD,SAASE,EAAOhB,GACb,GAAKA,EAAL,CAGA,IACIG,EAAQH,EAAOG,MADT,0GAEV,GAAIA,EAAO,CACV,IAAIW,EAAQN,WAAWL,EAAM,IAK3B,OAJQS,EAAMN,SAASH,EAAM,IAAK,EAAG,KAC7BS,EAAMJ,WAAWL,EAAM,IAAK,EAAG,KAC/BS,EAAMJ,WAAWL,EAAM,IAAK,EAAG,KAC/BS,EAAMG,MAAMD,GAAS,EAAIA,EAAO,EAAG,MAyCjD,SAASG,EAAWC,EAAMJ,GAIvB,YAHcK,IAAVL,IACDA,OAAqBK,IAAZD,EAAK,GAAmBA,EAAK,GAAK,GAEvC,QAAUA,EAAK,GAAK,KAAOA,EAAK,GAAK,KAAOA,EAAK,GAC9C,KAAOJ,EAAQ,IAc5B,SAASM,EAAeF,EAAMJ,GAI3B,MAAO,QAHCL,KAAKC,MAAMQ,EAAK,GAAG,IAAM,KAGZ,MAFbT,KAAKC,MAAMQ,EAAK,GAAG,IAAM,KAEA,MADzBT,KAAKC,MAAMQ,EAAK,GAAG,IAAM,KACY,OAASJ,GAASI,EAAK,IAAM,GAAK,IAUlF,SAASG,EAAWC,EAAMR,GAIvB,YAHcK,IAAVL,IACDA,OAAqBK,IAAZG,EAAK,GAAmBA,EAAK,GAAK,GAEvC,QAAUA,EAAK,GAAK,KAAOA,EAAK,GAAK,MAAQA,EAAK,GAAK,MACpDR,EAAQ,IAkBrB,SAASF,EAAMW,EAAKC,EAAKC,GACtB,OAAOhB,KAAKe,IAAIf,KAAKgB,IAAID,EAAKD,GAAME,GAGvC,SAASC,EAAUH,GACjB,IAAII,EAAMJ,EAAIK,SAAS,IAAIC,cAC3B,OAAQF,EAAItB,OAAS,EAAK,IAAMsB,EAAMA,EAnNxC,IAAIhB,EAAaf,EAAQ,KAEzBC,EAAOC,SACJC,QAASA,EACTc,QAASA,EACTiB,OA4GH,SAAgB9B,GACb,IAAIkB,EAAOnB,EAAQC,GACnB,OAAOkB,GAAQA,EAAKX,MAAM,EAAG,IA7G7BwB,OAgHH,SAAgB/B,GACd,IAAIsB,EAAOT,EAAQb,GACnB,OAAOsB,GAAQA,EAAKf,MAAM,EAAG,IAjH5BS,OAAQA,EACRgB,SAmHH,SAAkBhC,GACf,IAAIiC,EAAOlC,EAAQC,GACnB,OAAIiC,EACMA,EAAK,IAENA,EAAOpB,EAAQb,IACdiC,EAAK,IAENA,EAAOjB,EAAOhB,IACbiC,EAAK,QADV,GAzHLC,UA+HH,SAAmBjC,GAChB,MAAO,IAAMyB,EAAUzB,EAAI,IAAMyB,EAAUzB,EAAI,IAClCyB,EAAUzB,EAAI,KAhI3BkC,UAmIH,SAAmBjB,EAAMJ,GACtB,OAAIA,EAAQ,GAAMI,EAAK,IAAMA,EAAK,GAAK,EAC7BD,EAAWC,EAAMJ,GAEpB,OAASI,EAAK,GAAK,KAAOA,EAAK,GAAK,KAAOA,EAAK,GAAK,KAtI5DD,WAAYA,EACZmB,cAgJH,SAAuBlB,EAAMJ,GAC1B,OAAIA,EAAQ,GAAMI,EAAK,IAAMA,EAAK,GAAK,EAC7BE,EAAeF,EAAMJ,GAMxB,OAJCL,KAAKC,MAAMQ,EAAK,GAAG,IAAM,KAIb,MAHZT,KAAKC,MAAMQ,EAAK,GAAG,IAAM,KAGD,MAFxBT,KAAKC,MAAMQ,EAAK,GAAG,IAAM,KAEW,MAvJ5CE,eAAgBA,EAChBiB,UAgKH,SAAmBf,EAAMR,GACtB,OAAIA,EAAQ,GAAMQ,EAAK,IAAMA,EAAK,GAAK,EAC7BD,EAAWC,EAAMR,GAEpB,OAASQ,EAAK,GAAK,KAAOA,EAAK,GAAK,MAAQA,EAAK,GAAK,MAnK7DD,WAAYA,EACZiB,UA+KH,SAAmBC,EAAKzB,GAIrB,YAHcK,IAAVL,IACDA,OAAoBK,IAAXoB,EAAI,GAAmBA,EAAI,GAAK,GAErC,OAASA,EAAI,GAAK,KAAOA,EAAI,GAAK,MAAQA,EAAI,GAAK,UACrCpB,IAAVL,GAAiC,IAAVA,EAAc,KAAOA,EAAQ,IAAM,KAnLrE0B,QAsLH,SAAiBvC,GACf,OAAOwC,EAAaxC,EAAIM,MAAM,EAAG,MAenC,IAAIkC,KACJ,IAAK,IAAIC,KAAQ/B,EACd8B,EAAa9B,EAAW+B,IAASA"}}

node_modules/color-string/color-string.js

[Sean-Snow]

+1

[dotansimha]

Same here! 0.50.2

[stephenheron]

Looks like someone might have solved the issue : GeekyAnts/NativeBase#1348 (comment)

[dotansimha]

@stephenheron it didn't help me. Still getting:

Unhandled JS Exception: undefined is not an object (evaluating 'e.length')', reason: 'Unhandled JS Exception: undefined is not an object (evaluating 'e.length'), stack:
<unknown>@982:132
<unknown>@982:196
exports@982:395
<unknown>@979:218
<unknown>@979:72
t@2:620
<unknown>@977:39
t@2:620
<unknown>@976:285
t@2:620
<unknown>@975:287
t@2:620
<unknown>@974:446
t@2:620
<unknown>@968:293
t@2:620
<unknown>@967:126
t@2:620
<unknown>@966:265
t@2:620
<unknown>@965:178
t@2:620
<unknown>@964:144
t@2:620
<unknown>@963:194
t@2:620
<unknown>@962:213
t@2:620
<unknown>@960:233
t@2:620
<unknown>@930:278
t@2:620
<unknown>@910:118
t@2:620
<unknown>@844:135
t@2:620
<unknown>@843:99
t@2:620
<unknown>@648:187
t@2:620
<unknown>@356:132
t@2:620
<unknown>@12:44
t@2:620
<unknown>@2:154

Removing minification logic from node_modules/metro-bundler/src/JSTransformer/worker/minify.js seems to fix the issue.

[mauscoelho]

+1

[PvanHengel]

I did some digging around and was able to get it to "work".. Not sure if this is the same change as @dotansimha made or not... So perhaps the issue is actually related to changed made in https://github.com/mishoo/UglifyJS2

I modified the minify function in node_modules/metro-bundler/src/JSTransformer/worker/minify.js file from

  const result = uglify.minify(inputCode, {
    mangle: false,//{ toplevel: true },
    compress:false,
      
    output: {
      ascii_only: true,
      quote_style: 3,
      wrap_iife: true },

    sourceMap: {
      content: inputMap,
      includeSources: false },

    toplevel: true });


  if (result.error) {
    throw result.error;
  }

  return {
    code: result.code,
    map: result.map };

}

to

  const result = uglify.minify(inputCode, {
    mangle: false,//{ toplevel: true },
    compress:false,
      
    output: {
      ascii_only: true,
      quote_style: 3,
      wrap_iife: true },

    sourceMap: {
      content: inputMap,
      includeSources: false },

    toplevel: true });


  if (result.error) {
    throw result.error;
  }

  return {
    code: result.code,
    map: result.map };

}

[dotansimha]

@PvanHengel I just changed the code to return the original inputCode. Just wanted to verify that the issue is with the minification and not something else...

[andrew-wagner89]

I was able to fix the problem by resolving the color-convert package to use the pull request here: Qix-/color-convert/pull/49

just changed my package.json to include:
"resolutions": { "color-convert": "github:zbarbuto/color-convert" }

this is just a workaround though since other packages might declare the same var twice which breaks uglify