getDependencyConfig/getRPNMConfig does not work when node modules are not linked inside of react-native project

[joearasin]

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

(Write your answer here.)

Environment

1. react-native -v: 0.48.1
2. node -v: 8.4.0
3. npm -v: 5.4.2
4. yarn --version: 1.0.1

Then, specify:

• Target Platform: iOS + Android

• Development Operating System: macOS

• Build tools:

Steps to Reproduce

1. Create a yarn workspace project, with two workspaces: "common" and "native".
2. Add some dependencies to common.
3. Set "native" to depend on "common", and run yarn install.
4. Update native/rn-cli.config.js to read:

const config = {
  getProjectRoots() {
    return [path.resolve(__dirname), path.resolve(__dirname, '..')];
  },
};
export default config.

5. In the native project, run react-native link.

Expected Behavior

react-native link works properly.

Actual Behavior

react-native link throws "Cannot find module" errors

Reproducible Demo

https://github.com/joearasin/workspacesDemo

[joearasin]

As far as pointing at a line of code:

react-native/local-cli/core/index.js

Line 88 in 1e8f3b1

getDependencyConfig(packageName: string) {

seems to be only searching in the current project root for dependencies, even if there are multiple project roots specified

[joearasin]

I'm pretty sure the solution is to replace the folder finder with something along the lines of:

    const folder = this.getProjectRoots().map(root =>
      path.join(root, 'node_modules', packageName)
    ).filter(f => fs.existsSync(f))[0];

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.