Skip to content

Conversation

@gedeagas
Copy link
Contributor

@gedeagas gedeagas commented Aug 11, 2020

This PR updates the documentation to reflect the (pending) changes on LayoutAnimation configureNext.onAnimationDidFail callback.

See here for references facebook/react-native@777957c

@react-native-bot
Copy link

react-native-bot commented Aug 11, 2020

Deploy preview for react-native ready!

Built with commit dc2d5d2

https://deploy-preview-2136--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@gedeagas
Copy link
Contributor Author

@rachelnabors @Simek Hi guys, since this callback is fabric only and probably not called from the native side in non-fabric I am curious about the strategy here. how do you guys approach on documenting fabric only API with noop for non-fabric?

@Simek Simek added the Wait on future Release This indicates a PR that updates the doc to match a future release. label Aug 12, 2020
@Simek Simek changed the title Adding configureNext.onAnimationDidFail callback on LayoutAnimation ( Future Release ) Adding configureNext.onAnimationDidFail callback on LayoutAnimation Aug 12, 2020
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cpojer cpojer merged commit 3e5b9e4 into facebook:master Sep 29, 2020
slorber pushed a commit to react-native-website-migration/react-native-website that referenced this pull request Oct 9, 2020
* Update introduction.md (facebook#2181)

Hooks were introduced in React Native 0.59, not 0.58.

* adding snack player instead of images for flexbox (facebook#2171)

* adding snack player instead of images for flexbox

* chore: revert yarn.lock

* minor changes and improvements, prettier run on examples

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* UI & UX Design with InputAccessoryView (facebook#2183)

* UI Design with InputAccessoryView 

* Update inputaccessoryview.md

* small tweaks

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* update TextInput example, refs facebook#2187

* add TOC and improve formatting on the Android publishing page

* Modernize code examples in the direct manipulation section (facebook#2189)

* Modernize code examples in the direct manipulation section.

* small code tweaks/fixes + run code through Prettier

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* update Alert API page, include iOS specific functions from deprecated AlertIOS (facebook#2184)

Thanks for this one, @Simek!

* Update getting-started.md (facebook#2194)

Python2 & Python3 are both compatible

* fix homepage showcase app list graphical issue (facebook#2185)

Co-authored-by: R Nabors <[email protected]>

* docs: add matrix to transform (facebook#2197)

* Bump decompress from 4.2.0 to 4.2.1 in /website (facebook#2200)

Bumps [decompress](https://github.com/kevva/decompress) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/kevva/decompress/releases)
- [Commits](kevva/decompress@v4.2.0...v4.2.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Typo fix (facebook#2202)

* fixes facebook#2201, delete duplicated TOC, add note about removal to TabBarIOS pages

* docs: update deprecated usage of findNodeHandle in measureLayout (facebook#2199)

* docs: update deprecated usage of findNodeHandle in measureLayout

* minor text and Snack tweaks, prettier run

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* bump alex and node-fetch, fix new alex warning

* typo fix

* TextInput: Add `onPressIn` and `onPressOut` docs (facebook#2205)

Original summary by @yungsters in [1b994f9](facebook/react-native@b7b0e23):
Introduces support for `onPressIn` and `onPressOut` on the `TextInput` component.

This makes it possible to add visual feedback when users touch interact with `TextInput` components.

* Fix typos (facebook#2204)

* link out-of-tree platforms, add macOS platform, unify dashes on homepage (facebook#2186)

* link out-of-tree platforms, add macOS, unify dashes on homepage

* revert dashes changes

* update SectionList page, extract ViewToken, add labels (facebook#2191)

* update TextInput press callbacks type, refs facebook#2205

* Added workarounds for TextInputs (facebook#2203)

* Added workarounds for TextInputs

* provide info on the focus management using <Modal>

* small text tweaks

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* update Text page and add types, add LayoutEvent object page (facebook#2209)

* Incorrect command (facebook#2207)

https://github.com/react-native-community/cli/blob/master/docs/commands.md#run-android

`--variant [string]`

* Updated ScrollView `disableIntervalMomentum` doc. (facebook#2211)

* Remove announcement banner. (facebook#2213)

* Docs: Removing `onTextInput` prop from TextInput (facebook#2216)

* Removing `onTextInput` prop from TextInput doc.

* Removing `onTextInput` prop from TextInput on version 0.62 & 0.63.

* Signing not under General for me (facebook#2214)

* Update running-on-simulator-ios.md (facebook#2220)

We have to specify the generation for the iPhone SE simulator.

* [DOC] fixed errata in image doc (facebook#2221)

* Add documentation for Hermes sampling profiler (facebook#2159)

Co-authored-by: Saphal Patro <[email protected]>
Co-authored-by: R Nabors <[email protected]>
Co-authored-by: Saphal Patro <[email protected]>

* Adding Android NDK Installation Guide (facebook#2225)

* Docs: Integration with android fragment (facebook#2217)

Co-authored-by: Sebastien Bailouni <[email protected]>

* Add new option to ActionSheetIOS called disabledButtonsIndices (facebook#1898)

* Adding configureNext.onAnimationDidFail callback on LayoutAnimation (facebook#2136)

Co-authored-by: Christoph Nakazawa <[email protected]>

* Added Coinbase to showcase (facebook#2227)

* Added Coinbase to showcase

* Add Coinbase icon

* 0.63.3 release - update Pressable delay (facebook#2226)

* Improved README.md (facebook#2233)

* fix typo (facebook#2232)

* fix typo

fixes typo in "Using Custom Path Aliases with TypeScript" section (configure -> configuring)

* sentence rewrite

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* Add Shopify and Tableau to showcase (facebook#2228)

* Add Shopify in showcase

* Add Shopify icon

* Add Tableau to showcase

* Add tableau image asset

* Update Tableau icon

* updated debugging.md (facebook#2241)

fixed a typo in unhandled error

* Update appregistry.md (facebook#2246)

* Update out-of-tree-platforms.md (facebook#2243)

* Remove unnecessary python dependency (facebook#2250)

Python is not required anymore on windows platform. The only binary addon for react-native project are some deps of `ws`, [which now have prebuilt binary and are optional](https://github.com/websockets/ws#opt-in-for-performance-and-spec-compliance). 
Tested on a brand new windows 10 image with only node installed, the initiating process goes well.

* Update network.md to show android non ssl block (facebook#2245)

* Update network.md to show android non ssl block

added note for android's android:usesCleartextTraffic flag in manifest file to allow non ssl encrypted networking - to go alongside the existing note for ios.

* small text tweaks

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* remove link in native-modules-ios (facebook#2244)

Co-authored-by: luism3861 <[email protected]>

* Update textinput.md (facebook#2249)

* Update textinput.md

This will make it more clear for beginners who are trying to use onBlur to do a final action on their textInput's text value.

* formatting, text tweaks

Co-authored-by: Bartosz Kaszubowski <[email protected]>

* revert change to Netlify config due to V2 test merge

Co-authored-by: Georgios Kotziabassis <[email protected]>
Co-authored-by: Muhammad Saeed <[email protected]>
Co-authored-by: Bartosz Kaszubowski <[email protected]>
Co-authored-by: Mojtaba Vandaei <[email protected]>
Co-authored-by: Steven Luscher <[email protected]>
Co-authored-by: Pratik Khandelwal <[email protected]>
Co-authored-by: R Nabors <[email protected]>
Co-authored-by: Jesse Katsumata <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joe Bernard <[email protected]>
Co-authored-by: Thibault Malbranche <[email protected]>
Co-authored-by: Luis Miguel Alvarado <[email protected]>
Co-authored-by: Pramod Kotipalli <[email protected]>
Co-authored-by: Madd.is <[email protected]>
Co-authored-by: Kirill <[email protected]>
Co-authored-by: Ashwin Mothilal <[email protected]>
Co-authored-by: Christoph Nakazawa <[email protected]>
Co-authored-by: captDaylight <[email protected]>
Co-authored-by: ppichier <[email protected]>
Co-authored-by: Varunendra Pratap Singh <[email protected]>
Co-authored-by: Jessie Anh Nguyen <[email protected]>
Co-authored-by: Saphal Patro <[email protected]>
Co-authored-by: Saphal Patro <[email protected]>
Co-authored-by: Agastya Darma <[email protected]>
Co-authored-by: Steven Martin <[email protected]>
Co-authored-by: Sebastien Bailouni <[email protected]>
Co-authored-by: Luke Walczak <[email protected]>
Co-authored-by: Jessica Lin <[email protected]>
Co-authored-by: Vishal Vishwakarma <[email protected]>
Co-authored-by: Adam Hunter <[email protected]>
Co-authored-by: Jessica Lin <[email protected]>
Co-authored-by: Ashish Shakya <[email protected]>
Co-authored-by: Sunny Luo <[email protected]>
Co-authored-by: Alexander Sklar <[email protected]>
Co-authored-by: s-maurice <[email protected]>
Co-authored-by: luism3861 <[email protected]>
Co-authored-by: luism3861 <[email protected]>
Co-authored-by: Ralph Maamari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Wait on future Release This indicates a PR that updates the doc to match a future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants