Skip to content

Enable Performance panel by default #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huntie merged 1 commit into from
Oct 30, 2025
Merged

Enable Performance panel by default #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions front_end/core/rn_experiments/experimentsImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,13 +185,6 @@ Instance.register({
enabledByDefault: ({ isReactNativeEntryPoint }) => isReactNativeEntryPoint,
});

Instance.register({
name: RNExperimentName.ENABLE_PERFORMANCE_PANEL,
title: 'Enable Performance panel',
unstable: true,
enabledByDefault: ({ isReactNativeEntryPoint }) => !isReactNativeEntryPoint,
});

Instance.register({
name: RNExperimentName.ENABLE_NETWORK_PANEL,
title: 'Enable Network panel',
Expand Down
2 changes: 0 additions & 2 deletions front_end/core/root/Runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,6 @@ export const experiments = new ExperimentsSupport();
export enum RNExperimentName {
REACT_NATIVE_SPECIFIC_UI = 'react-native-specific-ui',
JS_HEAP_PROFILER_ENABLE = 'js-heap-profiler-enable',
ENABLE_PERFORMANCE_PANEL = 'enable-performance-panel',
ENABLE_NETWORK_PANEL = 'enable-network-panel',
}

Expand Down Expand Up @@ -341,7 +340,6 @@ export const enum ExperimentName {
JS_HEAP_PROFILER_ENABLE = RNExperimentName.JS_HEAP_PROFILER_ENABLE,
REACT_NATIVE_SPECIFIC_UI = RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
NOT_REACT_NATIVE_SPECIFIC_UI = '!' + RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
ENABLE_PERFORMANCE_PANEL = RNExperimentName.ENABLE_PERFORMANCE_PANEL,
ENABLE_NETWORK_PANEL = RNExperimentName.ENABLE_NETWORK_PANEL,
}

Expand Down
26 changes: 0 additions & 26 deletions front_end/entrypoints/rn_fusebox/FuseboxExperimentsObserver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ import * as UI from '../../ui/legacy/legacy.js';
import {FuseboxWindowTitleManager} from './FuseboxWindowTitleManager.js';

const UIStrings = {
/**
* @description Message for the "settings changed" banner shown when a reload is required for the Performance panel.
*/
reloadRequiredForPerformancePanelMessage:
'[Profiling build first run] One or more settings have changed. Please reload to access the Performance panel.',
/**
* @description Message for the "settings changed" banner shown when a reload is required for the Network panel.
*/
Expand Down Expand Up @@ -55,7 +50,6 @@ export class FuseboxFeatureObserver implements
if (unstable_isProfilingBuild) {
FuseboxWindowTitleManager.instance().setSuffix('[PROFILING]');
this.#hideUnsupportedFeaturesForProfilingBuilds();
this.#ensurePerformancePanelEnabled();
}

if (unstable_networkInspectionEnabled) {
Expand Down Expand Up @@ -91,26 +85,6 @@ export class FuseboxFeatureObserver implements
});
}

#ensurePerformancePanelEnabled(): void {
if (
!Root.Runtime.experiments.isEnabled(
Root.Runtime.ExperimentName.ENABLE_PERFORMANCE_PANEL,
)
) {
Root.Runtime.experiments.setEnabled(
Root.Runtime.ExperimentName.ENABLE_PERFORMANCE_PANEL,
true,
);

const inspectorView = UI.InspectorView?.InspectorView?.instance();
if (inspectorView) {
inspectorView.displayReloadRequiredWarning(
i18nString(UIStrings.reloadRequiredForPerformancePanelMessage),
);
}
}
}

#ensureNetworkPanelEnabled(): void {
if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.ENABLE_NETWORK_PANEL)) {
return;
Expand Down
2 changes: 0 additions & 2 deletions front_end/global_typings/react_native.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,5 @@ declare global {
var reactNativeOpenInEditorButtonImage: string|undefined;
// eslint-disable-next-line no-var,@typescript-eslint/naming-convention
var FB_ONLY__reactNativeFeedbackLink: string|undefined;
// eslint-disable-next-line no-var,@typescript-eslint/naming-convention
var FB_ONLY__enablePerformance: unknown;
}
}
1 change: 0 additions & 1 deletion front_end/panels/timeline/timeline-meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ UI.ViewManager.registerViewExtension({
title: i18nLazyString(UIStrings.performance),
commandPrompt: i18nLazyString(UIStrings.showPerformance),
order: 50,
experiment: globalThis.FB_ONLY__enablePerformance === true ? undefined : Root.Runtime.ExperimentName.ENABLE_PERFORMANCE_PANEL,
async loadView() {
const Timeline = await loadTimelineModule();
return Timeline.TimelinePanel.TimelinePanel.instance();
Expand Down
Loading