Skip to content

Conversation

@vzaidman
Copy link

Summary

Following #188, allow frames of the format ... skipping x frames (where x is a number) coming from Hermes for huge stack traces and track it as a special frame.

Test plan

For a 1000 stack created with recursion:
Screenshot 2025-07-21 at 16 42 01

Before:
Screenshot 2025-07-21 at 16 41 39

After:
Screenshot 2025-07-21 at 17 07 34

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

@meta-cla meta-cla bot added the cla signed label Jul 21, 2025
@vzaidman vzaidman force-pushed the allow-skipping-x-frames-parsing branch from e7ecb7c to e9f2055 Compare July 21, 2025 16:15
@vzaidman vzaidman requested review from hoxyq and motiz88 July 23, 2025 08:56
@vzaidman vzaidman force-pushed the allow-skipping-x-frames-parsing branch from e9f2055 to 3b58e23 Compare July 23, 2025 13:38
@vzaidman vzaidman requested a review from hoxyq July 23, 2025 13:48
@hoxyq hoxyq mentioned this pull request Jul 23, 2025
3 tasks
@vzaidman vzaidman force-pushed the allow-skipping-x-frames-parsing branch from 3b58e23 to fb5038f Compare July 23, 2025 15:15
@vzaidman vzaidman merged commit 12ae91a into main Jul 23, 2025
5 checks passed
@vzaidman vzaidman deleted the allow-skipping-x-frames-parsing branch July 23, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants