Refactor split pane bugfix to avoid magic numbers #620
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
shriah
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
frontend/SplitPane.js
Outdated
| <div style={rightStyle}> | ||
| {this.props.right()} | ||
| <div style={rightStyles}> | ||
| <Draggable |
There was a problem hiding this comment.
Nitpick: please use two space indentation
|
This looks great, thanks. I won’t pretend to understand it, as CSS is not my strong side. But it does look cleaner. 😃 |
3 participants
Fixed #615
The fix is to create a wrapper element around the right pane without any padding or margin so we can set the width or height we calculate directly to it. http://recordit.co/TU3CHcHNbN
I also changed the min width of the right pan to 150px because at 100px it was getting too squashed to the right.