Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions agent/__tests__/dehydrate-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,12 @@ describe('dehydrate', () => {
expect(result.a.b.c).toEqual({type: 'array', name: 'Array', meta: {length: 2}});
expect(result.a.b.d).toEqual({type: 'object', name: 'Something', meta: {}});
});

it('returns readable name for dates', () => {
var d = new Date();
var object = {a: d };
var cleaned = [];
var result = dehydrate(object, cleaned);
expect(result.a).toEqual({type: 'date', name: d.toString(), meta: {uninspectable: true}});
});
});
14 changes: 13 additions & 1 deletion agent/dehydrate.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ function getPropType(data: Object): string | null {
if (data[Symbol.iterator] === 'function') {
return 'iterator';
}
if (Object.prototype.toString.call(data) === '[object Date]') {
return 'date';
}
}

return type;
Expand Down Expand Up @@ -136,11 +139,20 @@ function dehydrate(data: Object, cleaned: Array<Array<string>>, path?: Array<str
case 'typed_array':
case 'iterator':
return createDehydrated(type, data, cleaned, path);

case 'date':
cleaned.push(path);
return {
name: data.toString(),
type: 'date',
meta: {
uninspectable: true,
},
};
case 'object':
if (level > 2 || (data.constructor && typeof data.constructor === 'function' && data.constructor.name !== 'Object')) {
return createDehydrated(type, data, cleaned, path);
} else {

var res = {};
for (var name in data) {
res[name] = dehydrate(data[name], cleaned, path.concat([name]), level + 1);
Expand Down
6 changes: 6 additions & 0 deletions frontend/DataView/previewComplex.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ function previewComplex(data: Object) {
{data[consts.name] + '{…}'}
</span>
);
case 'date':
return (
<span style={valueStyles.date}>
{data[consts.name]}
</span>
);
case 'symbol':
return (
<span style={valueStyles.symbol}>
Expand Down
2 changes: 2 additions & 0 deletions frontend/PropVal.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ function previewProp(val: any, nested: boolean) {
}

switch (val[consts.type]) {
case 'date':
return <span style={valueStyles.date}>{val[consts.name]}</span>;
case 'function':
return <span style={valueStyles.func}>{val[consts.name] || 'fn'}()</span>;
case 'object':
Expand Down
4 changes: 4 additions & 0 deletions frontend/value-styles.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ module.exports = {
color: '#1c00cf',
},

date: {
color: 'rgb(33, 33, 33)',
},

number: {
color: '#1c00cf',
},
Expand Down