Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Flow errors with npm #817

@zinoviev

Description

@zinoviev

The last PR builds failed with flow errors on promise package

I spot these on last two PR #569 and #677 and it's true for master as well

On my local environment, everything is fine with yarn but doesn't work with npm
Promise is fbjs dependency ^7.03, with yarn it's resolved with 7.1.1 version for npm it's 7.3.0

7.3.0 promise kills our build
then/promise#135

Not sure how to deal with it - wait for promise team for fix or pin promise version in fbjs

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions