Fix CQS signal modernize-use-emplace in fbcode/quic/api

Differential Revision: D82519232

fbshipit-source-id: 036baa9d7876ea3bd15f5025449e30b0ec8bbe1d

Author: generatedunixname89002005287564

quic/api/test/QuicTransportBaseTest.cpp

@@ -4216,8 +4216,7 @@ TEST_P(QuicTransportImplTestBase, HandleKnobCallbacks) {
   BufPtr buf(folly::IOBuf::create(data.size()));
   memcpy(buf->writableData(), data.data(), data.size());
   buf->append(data.size());
-  conn->pendingEvents.knobs.emplace_back(
-      KnobFrame(knobSpace, knobId, std::move(buf)));
+  conn->pendingEvents.knobs.emplace_back(knobSpace, knobId, std::move(buf));
 
   EXPECT_CALL(connCallback, onKnobMock(knobSpace, knobId, _))
       .WillOnce(Invoke([](Unused, Unused, Unused) { /* do nothing */ }));

quic/api/test/QuicTransportTest.cpp

@@ -252,10 +252,10 @@ void verifyCorrectness(
   BufQueue retxBufCombined;
   std::vector<StreamBuffer> rtxCopy;
   for (auto& itr : stream->retransmissionBuffer) {
-    rtxCopy.push_back(StreamBuffer(
+    rtxCopy.emplace_back(
         folly::IOBuf::copyBuffer(itr.second->data.getHead()->getRange()),
         itr.second->offset,
-        itr.second->eof));
+        itr.second->eof);
   }
   std::sort(rtxCopy.begin(), rtxCopy.end(), [](auto& s1, auto& s2) {
     return s1.offset < s2.offset;