Fix CQS signal modernize-use-emplace in fbcode/quic/state

Differential Revision: D82288893

fbshipit-source-id: d0d01560b3b06852ee2aa2dd70ce40872a941ac7

Author: generatedunixname89002005287564

quic/state/QuicAckFrequencyFunctions.cpp

@@ -25,7 +25,7 @@ void requestPeerAckFrequencyChange(
   frame.updateMaxAckDelay = maxAckDelay.count();
   frame.reorderThreshold = reorderThreshold;
   frame.sequenceNumber = conn.nextAckFrequencyFrameSequenceNumber++;
-  conn.pendingEvents.frames.push_back(frame);
+  conn.pendingEvents.frames.emplace_back(frame);
 }
 
 std::chrono::microseconds clampMaxAckDelay(

quic/state/SimpleFrameFunctions.cpp

@@ -78,7 +78,7 @@ void updateSimpleFrameOnPacketLoss(
     case QuicSimpleFrame::Type::StopSendingFrame: {
       const StopSendingFrame& stopSendingFrame = *frame.asStopSendingFrame();
       if (conn.streamManager->streamExists(stopSendingFrame.streamId)) {
-        conn.pendingEvents.frames.push_back(stopSendingFrame);
+        conn.pendingEvents.frames.emplace_back(stopSendingFrame);
       }
       break;
     }
@@ -91,11 +91,11 @@ void updateSimpleFrameOnPacketLoss(
       break;
     }
     case QuicSimpleFrame::Type::PathResponseFrame: {
-      conn.pendingEvents.frames.push_back(*frame.asPathResponseFrame());
+      conn.pendingEvents.frames.emplace_back(*frame.asPathResponseFrame());
       break;
     }
     case QuicSimpleFrame::Type::HandshakeDoneFrame: {
-      conn.pendingEvents.frames.push_back(*frame.asHandshakeDoneFrame());
+      conn.pendingEvents.frames.emplace_back(*frame.asHandshakeDoneFrame());
       break;
     }
     case QuicSimpleFrame::Type::NewConnectionIdFrame:

quic/state/StateData.cpp

@@ -142,7 +142,7 @@ QuicConnectionStateBase::retireAndSwitchPeerConnectionIds() {
     return false;
   }
   DCHECK(currentConnIdDataIt != end);
-  pendingEvents.frames.push_back(
+  pendingEvents.frames.emplace_back(
       RetireConnectionIdFrame(currentConnIdDataIt->sequenceNumber));
   mainPeerId = replacementConnIdDataIt->connId;