Skip to content

[lexical-react] Bug Fix: LexicalMenu position menu immediately regression #7669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

[lexical-react] Bug Fix: LexicalMenu position menu immediately regression #7669

merged 1 commit into from
Jul 3, 2025

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Jul 3, 2025 •
edited
Loading

Description

The LexicalMenu change in #7181 caused a regression where extra DIVs were left in the DOM, sometimes taking up space and preventing interaction with the elements below.

Closes #7668

Test plan

First follow #7668 repro steps

Before

> [...new Set([...document.querySelectorAll('div[aria-label="Typeahead menu"]')].map((el) => el.style.cssText))]
(2) ['display: block; position: absolute;', 'display: block; position: absolute; left: 216px; height: 17.5px; width: 21.0938px; top: 166.273px;']

After

> [...new Set([...document.querySelectorAll('div[aria-label="Typeahead menu"]')].map((el) => el.style.cssText))]
['display: block; position: absolute;']

@vercel Vercel
Copy link

vercel bot commented Jul 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 5:16pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 5:16pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2025
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Jul 3, 2025
@etrepum etrepum mentioned this pull request Jul 3, 2025
Closed
@etrepum etrepum added this pull request to the merge queue Jul 3, 2025
Merged via the queue into facebook:main with commit d541fe8 Jul 3, 2025
43 checks passed
@etrepum etrepum mentioned this pull request Jul 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

@lilshady lilshady Awaiting requested review from lilshady lilshady is a code owner

@takuyakanbr takuyakanbr Awaiting requested review from takuyakanbr takuyakanbr is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: LexicalMenu typeahead-menu leaves dangling DIVs which can prevent clicks
3 participants
@etrepum @zurfyx @facebook-github-bot