[lexical-devtools-core] Bug Fix: Allow CustomPrintNodeFn to return undefined #7619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CustomPrintNodeFn
type is strictly typed to returnstring
. This causes a TypeScript error if your provided function returnsundefined
to fall back to the default node printing logic, even though the runtime code handles this scenario.CustomPrintNodeFn
type definition to bestring | undefined
. This aligns the type with the existing runtime behavior and resolves the TypeScript error.Closes #7612
Test plan
Before
If you provided a
customPrintNode
function like this, you would encounter a TypeScript error:After
With the updated type definition, the above code will no longer produce a TypeScript error. The type checking will succeed, reflecting the actual supported behavior of the
generateContent
function inlexical-devtools-core
.