Skip to content

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Mar 3, 2025

v0.27.0 ad-hoc release to address v0.26.0 regressions.

Breaking Changes

Core:

  • [Breaking Changes][lexical] Bug Fix: Address deleteLine regression in #7248 #7270 - To handle platform differences and avoid piercing shadow roots, arrow key navigation for RangeSelection is now handled by lexical in more scenarios when crossing the boundaries of elements. This should only affect "exotic" custom element nodes such as TableNode. All code in @lexical/table has been updated accordingly, but if you have something like a custom table implementation then it may require additional updates (probably in the direction of removing workarounds rather than adding them).

Highlights

Core:

Playground:

Utils:

Collab/Table:

What's Changed

New Contributors

Full Changelog: v0.26.0...v0.27.0

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 4:30pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 4:30pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2025
@etrepum etrepum added extended-tests Run extended e2e tests on a PR and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 3, 2025
Copy link
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to amend the 'hrSelected" to "hr:active" CSS approach before release.

@etrepum
Copy link
Collaborator Author

etrepum commented Mar 3, 2025

@ivailop7

Would be nice to amend the 'hrSelected" to "hr:active" CSS approach before release.

I think that can be revisited later, this release effectively just renames the hardcoded class name 'selected' to the configured class in the theme (or 'selected' if not present). If you don't change your theme then nothing changes. I don't think the :active pseudo-class will work here since this is a NodeSelection not a native selection, and I don't think holding up this fix release makes sense for a nit that only affects the playground and will not change behavior in any way unless you also change your theme to match this one.

@etrepum
Copy link
Collaborator Author

etrepum commented Mar 3, 2025

Pretty sure those are flaky test runs, will restart failed jobs after they finish

@etrepum etrepum added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 4403db1 Mar 3, 2025
43 checks passed
@etrepum etrepum mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants