Skip to content

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Jan 7, 2021

Signed-off-by: Reece Dunham [email protected]

Motivation

Prompts is generally better, see facebook/create-react-app#10083 for more context.

I'll switch @docusaurus/core over as well when I have more time.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I have personally confirmed it still works after these changes.

Related PRs

facebook/create-react-app#10083

@RDIL RDIL requested review from lex111 and slorber as code owners January 7, 2021 17:41
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 7, 2021
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, copyUntypedFiles kept failing on this file locally, so I just ported it to TypeScript.

@github-actions
Copy link

github-actions bot commented Jan 7, 2021

Size Change: -2 B (0%)

Total Size: 26.7 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.83 kB -1 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Jan 7, 2021

✔️ Deploy preview for docusaurus-2 ready!
Built without sensitive environment variables

🔨 Explore the source changes: b3e60b6

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5ff747b54c48980007998a98

😎 Browse the preview: https://deploy-preview-4012--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 7, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 85
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4012--docusaurus-2.netlify.app/classic/

@slorber slorber changed the title [v2] docusaurus-init: switch from inquirer to prompts chore(v2): docusaurus-init: switch from inquirer to prompts Jan 11, 2021
@slorber
Copy link
Collaborator

slorber commented Jan 11, 2021

LGTM thanks 👍

Seems to have benefits to do the switch, and would be happy to remove it from core as well.
It seems used in some core deps like react-dev-utils too, I guess we'd need to upgrade it as well.

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jan 11, 2021
@slorber slorber merged commit a406a3c into facebook:master Jan 11, 2021
@RDIL RDIL deleted the prompts branch January 11, 2021 14:43
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants