feat(faster): upgrade Rspack to 1.5, use lazyBarrel experiment, remove deprecated option #11415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lazyCompilation option
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: -2.18 kB (-0.02%) Total Size: 11.7 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
Size Change: +273 B (0%) Total Size: 12.1 MB ℹ️ View Unchanged
|
Collaborator
Author
|
For history: this warning seems hardless, the lib hasn't been published since 7 years and we already used it before. If it's compromised (which doesn't seem so after inspecting the package), then Docusaurus has always been compromised.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Note: I'm not upgrading to 1.5.4+ because there's a bug affecting our website (web-infra-dev/rspack#11717)
It doesn't affect newly initialized Docusaurus Faster sites, and we have no bug reports yet, so it's probably not worth adding an upper semver range for now.
Test Plan
CI
Test links
https://deploy-preview-11415--docusaurus-2.netlify.app/
Related issues/PRs
I'd like to see if newer Rspack could improve bundle size after upgrading to DocSearch v4: #11327