Skip to content

Add pre-eject message about new features in v2 #5954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Add pre-eject message about new features in v2 #5954

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d5b170
Add pre-eject message about new features in v2
iansu Dec 3, 2018
fbfe366
Make message bold
iansu Dec 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/react-scripts/scripts/eject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ function getGitStatus() {
}
}

console.log(
chalk.cyan(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe bold as well?

'NOTE: Create React App 2 supports TypeScript, SASS, CSS Modules and more without ejecting: ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Sass

Suggested change
'NOTE: Create React App 2 supports TypeScript, SASS, CSS Modules and more without ejecting: ' +
'NOTE: Create React App 2 supports TypeScript, Sass, CSS Modules and more without ejecting: ' +

'https://reactjs.org/blog/2018/10/01/create-react-app-v2.html'
)
);
console.log();

inquirer
.prompt({
type: 'confirm',
Expand Down