Skip to content

Only use cached yarn.lock if using the default yarn registry #5745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Only use cached yarn.lock if using the default yarn registry #5745

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0454543
Only use cached yarn.lock if using the default yarn registry
timsnadden Nov 7, 2018
fb0b775
Merge branch 'master' into checkYarnRegistry
timsnadden Dec 7, 2018
abc2e59
Update packages/create-react-app/createReactApp.js
NMinhNguyen Jan 17, 2019
8c48bfa
Remove duplicate declaration from incorrect merge
timsnadden Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/create-react-app/createReactApp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,10 @@ function createApp(
);

const useYarn = useNpm ? false : shouldUseYarn();
const yarnUsesDefaultRegistry =
execSync('yarn config get registry').toString() ===
'https://registry.yarnpkg.com';

const originalDirectory = process.cwd();
process.chdir(root);
if (!useYarn && !checkThatNpmCanReadCwd()) {
Expand Down Expand Up @@ -267,7 +271,7 @@ function createApp(
}
}

if (useYarn) {
if (useYarn && yarnUsesDefaultRegistry) {
fs.copySync(
require.resolve('./yarn.lock.cached'),
path.join(root, 'yarn.lock')
Expand Down