Skip to content

Change import syntax from typescript declaration #5559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2018
Merged

Change import syntax from typescript declaration #5559

merged 1 commit into from
Oct 24, 2018
+1 −1

Conversation

brunolemos
Copy link
Contributor

@brunolemos brunolemos commented Oct 24, 2018 •
edited
Loading

It's not a syntax babel supports inside .ts files so we better use the supported syntax here

And it has to use * as React because we made allowSyntheticDefaultImports: true optional.

@Timer Timer added this to the 2.1 milestone Oct 24, 2018
@Timer Timer merged commit dc7cdf4 into facebook:master Oct 24, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
@brunolemos @Timer
Change import syntax from typescript declaration (facebook#5559)
52faf46
nate770 pushed a commit to ONTW/create-react-app that referenced this pull request Oct 30, 2018
@brunolemos @nate770
Change import syntax from typescript declaration (facebook#5559)
625177d
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed issue: typescript tag: internal

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@brunolemos @Timer @facebook-github-bot