Added env (IGNORE_OPEN) before openBrowser.

[qhoekman]

This env is chosen to make sure that there isn't a browser window showing up, when developing a Electron application. The start.js script can be used in the Electron index.js for launching the dev server and loading its url.

[ghost]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

[ghost]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[gaearon]

Hey! Thanks for the PR.

I think we won’t take it. I understand this is minimal, but we specifically don’t plan to tailor this tool for Electron apps. It would be frustrating if we merged this now, only to break something else later on.

I would encourage you to fork react-scripts provided by this package and publish react-electron-scripts or something like this, fine tuned to your use case.

[aeneasr]

Unfortunately this causes my docker-compose setup to fail:

?[33mdeveloper-ui_1  |?[0m > [email protected] start /usr/src/app
?[33mdeveloper-ui_1  |?[0m > react-scripts start
?[33mdeveloper-ui_1  |?[0m
?[33mdeveloper-ui_1  |?[0m ?cStarting the development server...
?[33mdeveloper-ui_1  |?[0m
?[33mdeveloper-ui_1  |?[0m internal/child_process.js:302
?[33mdeveloper-ui_1  |?[0m     throw errnoException(err, 'spawn');
?[33mdeveloper-ui_1  |?[0m     ^
?[33mdeveloper-ui_1  |?[0m
?[33mdeveloper-ui_1  |?[0m Error: spawn EACCES
?[33mdeveloper-ui_1  |?[0m     at exports._errnoException (util.js:1007:11)
?[33mdeveloper-ui_1  |?[0m     at ChildProcess.spawn (internal/child_process.js:302:11)
?[33mdeveloper-ui_1  |?[0m     at Object.exports.spawn (child_process.js:383:9)
?[33mdeveloper-ui_1  |?[0m     at module.exports (/usr/src/app/node_modules/react-scripts/node_modules/opn/index.js:75:24)
?[33mdeveloper-ui_1  |?[0m     at openBrowser (/usr/src/app/node_modules/react-scripts/scripts/start.js:173:3)
?[33mdeveloper-ui_1  |?[0m     at Server.devServer.listen (/usr/src/app/node_modules/react-scripts/scripts/start.js:308:5)
?[33mdeveloper-ui_1  |?[0m     at Server.g (events.js:286:16)
?[33mdeveloper-ui_1  |?[0m     at emitNone (events.js:86:13)
?[33mdeveloper-ui_1  |?[0m     at Server.emit (events.js:185:7)
?[33mdeveloper-ui_1  |?[0m     at emitListeningNT (net.js:1279:10)
?[33mdeveloper-ui_1  |?[0m     at _combinedTickCallback (internal/process/next_tick.js:71:11)
?[33mdeveloper-ui_1  |?[0m     at process._tickCallback (internal/process/next_tick.js:98:9)
?[33mdeveloper-ui_1  |?[0m
?[33mdeveloper-ui_1  |?[0m npm info lifecycle [email protected]~start: Failed to exec start script