chore(lint): lint all files #11727
Closed
chore(lint): lint all files #11727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raix
approved these changes
Dec 8, 2021
iansu
approved these changes
Dec 8, 2021
Contributor
iansu
left a comment
iansu
left a comment
There was a problem hiding this comment.
Nice! Thanks for doing this.
lukekarrys
force-pushed
the
lk/lint-all
branch
from
b8ddf7f to
96d11a8
Compare
This change consolidates all lint rules and paths to the root of the repo, and runs them as part of the `lint` workflow.
lukekarrys
force-pushed
the
lk/lint-all
branch
from
76ad129 to
9f8d75e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change consolidates all lint rules and paths to the root of the repo, and runs them as part of the
lintworkflow.There were only a few manual changes to make, so I opted to make it lint everything, meaning
eslintfor all*.jsfiles andprettierfor all file types it knows about by default. I can easily revert and ignore any files that shouldn't be linted, but as a first pass it was easier to lint everything.