PWA / Service worker breaking production deployments

[ro-savage]

EDIT: Issue appears to be with Firebase only

Service workers aren't refreshing index.html and therefore new deploys are showing old bundles.

This means production websites or really all deployed sites that use a single url/domain can not be updated.

PR #2441 - Is a hotfix (if needed) that just removes the service worker and updates docs to say they have been disabled temporarily.

@gaearon @Timer @jeffposnick @addyosmani

Steps to reproduce

• create-react-app sw-test
• cd sw-test
• npm install
• npm run build
• cd build

Deploy with firebase

• firebase deploy
• Visit site https://[project].firebaseapp.com. Confirm working.
• Change app.js
• npm run build
• cd build
• deploy firebase

Check website

• Visit site again and no changes shown. DevTools shows SW is providing index.html and old bundles.
• Force refresh a few times. No difference.
• Delete service worker.
• Refresh.
• See correctly updated site.

Can someone else confirm this is affecting them?

I am hoping I am doing something wrong and this isn't affecting every production deploy.

[ro-savage]

Additionally, you can not remove the service worker because if you try to unregister in a new deploy, the user will never see the updated bundle.

[gaearon]

cc @jeffposnick

[bunshar]

Looks like something to do with "now". Works for me - Checked with "surge" and localhost

[gaearon]

cc @rauchg

[ro-savage]

Thank you @bunshar !

I tried surge on a new project built from scratch. And it working as expected.

Deployed same app on now and its working as expected.

No idea what happened or what I did different.

Happy to close this and assume I managed to screw something up multiple times and over-react.

I will keep an eye on my projects and see if I can narrow down what happened.

[ro-savage]

Still running into issues on firebase.

Deploying same newly create app to now, surge and firebase.

now and surge are updating. firebase is not. (newly created project: https://cra-sw.firebaseapp.com/)

Will see if its working tomorrow and will contact firebase and see what they say.

[ro-savage]

Just to prove I am not crazy and this is a thing on firebase.

Deploying changes with serve, now, surge and firebase.
Approximately 3 minutes
https://www.youtube.com/watch?v=oYy-WqkgS1Q

[gaearon]

Let’s keep it open and wait for @jeffposnick to help with diagnosing this.