Fix issue with missing require in later active_support releases #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused bad_attributes attr_reader on `Hermod::Validators::Attributes`
Added missing require in `Hermod::XmlSectionBuilder`
Uses #_ (also aliased as #value or #expect) as a monad to test expectations instead of monkey-patching Object. Old expectations are due to be deprecated in Minitest 6
gerardm-fa
force-pushed
the
fix-minitest-deprecations-warnings-errors
branch
from
946897b to
a4ee71d
Compare
percysnoodle
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including apps started failing in some cases with a missing
require "date".This release also fixes warnings and deprecations when running the minitest suite:
bad_attributesmethod#expectmonads instead of using the money-patchedObjectmethods, which will be removed in Minitest 6.