Custom Commands don't appear to work in Eclipse Juno / 4.2

[ziesemer]

When trying to execute any custom command (including the ones supplied by default), nothing happens - but the following is logged to the Eclipse error log:

Error
Failed to execute item de.bastiankrol.startexplorer.customCommand034

org.eclipse.core.commands.NotHandledException: There is no handler to execute for command de.bastiankrol.startexplorer.customCommand034
    at org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:494)
    at org.eclipse.ui.menus.CommandContributionItem.handleWidgetSelection(CommandContributionItem.java:824)
    at org.eclipse.ui.menus.CommandContributionItem.access$19(CommandContributionItem.java:810)
    at org.eclipse.ui.menus.CommandContributionItem$5.handleEvent(CommandContributionItem.java:800)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4169)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3758)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1022)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:916)
    at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:86)
    at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:585)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:540)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
    at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:353)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:180)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:601)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:629)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:584)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1438)

Eclipse build 20120614-1722, Windows 7 SP1 x64, Java 1.7.0_05 64-bit.

[basti1302]

Thanks for the report. I just downloaded the Juno release and can reproduce the bug. It seems, StartExplorer custom commands are not compatible with Juno. I have not yet investigated this in detail but I will try to have a look at it as soon as possible.

[basti1302]

I did a little more digging/debugging. The handler is clearly attached to the command but the Eclipse Juno code ignores that and tries to get a handler by some lookup algorithm which I do not really understand. To me this looks like a bug. On the other I, I use some Eclipse infrastructure which is marked with something like "plug-in imlementors should not use it, it's Eclipse-internal stuff" - so this might be the problem. I'm pretty sure this not has not been there when I first implemented the custom command feature (a few years ago).

I'll try to clarify this, but I guess it will take a while.

[basti1302]

Has been fixed in version 1.2.1.

Mark, could you please take a moment and verify the fix?

[ziesemer]

Confirmed fixed. Thanks!