Skip to content

fix #194: use formfield_callback to assume HTTPS scheme #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

M3nace
Copy link

@M3nace M3nace commented Jul 2, 2025


name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo


Describe your changes
In SettingForm's Meta class, use the "formfield_callback" to apply the "assume_scheme" option on potential URLField.

Related issue
#194

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.51%. Comparing base (2c20097) to head (25ceaeb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   85.31%   85.51%   +0.20%     
==========================================
  Files          21       21              
  Lines         429      435       +6     
==========================================
+ Hits          366      372       +6     
  Misses         63       63              
Flag Coverage Δ
unittests 85.51% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant