Skip to content

Conversation

JanBednarik
Copy link

Active tablinks uses module background color for texts now. That may make them barely visible:

tablink-old

Fixed by changing them to module text color which should be more appropriate:

tablink-new

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 97.58% // Head: 97.57% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (93adfa9) compared to base (186e78b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   97.58%   97.57%   -0.02%     
==========================================
  Files          36       36              
  Lines         414      412       -2     
==========================================
- Hits          404      402       -2     
  Misses         10       10              
Flag Coverage Δ
unittests 97.57% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
admin_interface/models.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fabiocaccamo
Copy link
Owner

Hi @JanBednarik
thank you for reporting the problem and for the PR.

I was not satisfied with these colors from the beginning because there is not a logic correlation between the initial color, the color on hover and the color for active state.

I need to think a little bit to what the best solution could be here...

@fabiocaccamo
Copy link
Owner

Maybe using the hover color even for the active state is the best/safest thing to do here.

@JanBednarik
Copy link
Author

In my theme I'm using red for hover color. That would take too much attention on active tab. Maybe that module text color is not ideal, but should be more universal.

Perhaps you can create new color setting just for active tab? That would solve it for all use cases.

@fabiocaccamo
Copy link
Owner

Yes, adding a css_generic_link_active_color would solve any doubt and would also be available for possible other future cases.

@fabiocaccamo
Copy link
Owner

@mjwalter field available in 0.25.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants