Project updated to target .NET Standard 2.0 and async methods interception #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter compatibility
Currently interception of async methods doesn't work as expected. Added Castle.Core.AsyncInterceptor and used IAsyncInterceptor in it to intercept async methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package for this solution in nuget only supports .NET Core 2.2 which I tried to use in one of my class libraries. But it didn't work because my library was targetted for .NET Standard 2.0. By adding support for .NET Standard 2.0, this library will be available for large number of other project types as well.
This pull request contains changes only for project files to target .NET Standard 2.0 and made change in InvocationContext.cs to support libraries in .NET Standard 2.0.
This also contains interception for async methods, I have used
Castle.Core.AsyncInterceptorfor that. I've done my best to preserve way you implemented it, please let me know if you need any changes to it.