-
-
Notifications
You must be signed in to change notification settings - Fork 32
fix: increase dbus-send reply timeout #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
it fixes an error "Error org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken."
As I already tried to explain in #55, I don't think increasing the timeout is the solution. I have seen response times longer than five seconds in some situations, on other machines it might be even worse. |
A timeout of one second for something that should only take a few milliseconds is already plenty. A more than 500-fold time increase is very likely some buggy behavior, so there are no guarantees a response will be received within 2, 3, 5 or even 10 seconds on any affected system. So increasing the timeout just defers this problem, and is no proper solution. |
but it can be a crutch that will fix 80 percent of the situations until a solution is found Also, for gnome systems we could use
|
I have already proposed a solution in my original issue. If I had thought increasing the timeout would be fine, I'd have done that. And even if increasing the timeout was the consensus, we'd have to agree upon a time that actually fixes 80 % of the situations, as you say. The response time seems to vary wildly, and in a different setup 10 or 20 seconds might be needed. By the way, issue 45 does not seem to be related to this problem or your suggested fix at all, so I don't know why you're referencing it? |
yeah, my fault. it is not related. May be this plugin should provide a "command" option where every one could use what they want to detect current theme. |
Yes, that's what #46 does. |
this change is fine by me, but do u think it's still useful in some way? (in general having a bigger timeout seems like a ok idea) |
it fixes an error "Error org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken."
it is potentially fix for: