IBX-6185: Added more PHP file types to default upload blocklist #3153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
Steveb-p
approved these changes
Jul 17, 2023
Contributor
Steveb-p
left a comment
Steveb-p
left a comment
There was a problem hiding this comment.
A regexp would be more applicable to the case, although then again executing uploaded files in any interpreter should not be possible due to webserver settings 😄
konradoboza
approved these changes
Jul 17, 2023
alongosz
changed the title
alongosz
approved these changes
Jul 17, 2023
Member
Author
|
@Steveb-p A plain list is easier for our users, I think. And there's even a potential risk in running a regexp on user supplied data. Yes, the webserver should block execution anyway. Security is like onions, it has layers... 👹 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.5The file upload blocklist includes file types that are not allowed to be uploaded.
https://github.com/ibexa/core/blob/main/src/bundle/Core/Resources/config/default_settings.yml#L111
Some variants of PHP file types are not included by default, we should add them:
php4, php5, phps
Doc PR for the security checklist: ibexa/documentation-developer#2059
Checklist:
Provided automated test coverage.Ran PHP CS Fixer for new PHP code (use$ composer fix-cs).@ezsystems/engineering-team).