EZP-31039: Skip requirement of sort params when updating Location via REST #3071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
approved these changes
Oct 23, 2020
adamwojs
approved these changes
Oct 26, 2020
Member
|
@barw4 Please remember to open PR in ezplatform-rest repository as well. |
lserwatka
approved these changes
Oct 26, 2020
3 tasks
tomaszszopinski
approved these changes
Oct 27, 2020
tomaszszopinski
left a comment
tomaszszopinski
left a comment
There was a problem hiding this comment.
QA approved on eZPlatform 2.5.14 with diff & path.
Member
Author
|
Merged into 1.1: ezsystems/ezplatform-kernel@73852d5 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateLocationAPI method doesn't require the existence of sort params inLocationUpdateStruct(it will use params already stored in the Location itself), we can remove them when parsing REST data.Related PR: ezsystems/ezplatform-admin-ui-modules#287
TODO:
$ composer fix-cs).