EZP-32157: Added option to choose SA when creating custom alias #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barw4
changed the title
4 tasks
barw4
changed the title
Steveb-p
reviewed
Oct 27, 2020
src/lib/Form/EventListener/AddSiteAccessFieldBasedOnContentListener.php
Outdated
Show resolved
Hide resolved
src/lib/Form/EventListener/AddSiteAccessFieldBasedOnContentListener.php
Outdated
Show resolved
Hide resolved
src/lib/Form/EventListener/AddSiteAccessFieldBasedOnContentListener.php
Outdated
Show resolved
Hide resolved
src/lib/Form/EventListener/AddSiteAccessFieldBasedOnContentListener.php
Outdated
Show resolved
Hide resolved
alongosz
requested changes
Oct 28, 2020
Member
alongosz
left a comment
alongosz
left a comment
There was a problem hiding this comment.
Why was this added via listener instead directly to a form? Don't know much about AdminUI architecture...
src/lib/Form/EventListener/AddSiteAccessFieldBasedOnContentListener.php
Outdated
Show resolved
Hide resolved
Member
Author
@alongosz I guess in order to keep it clean. In this form type there are 4 other listeners working exactly the same. |
DominikaK
reviewed
Oct 28, 2020
src/bundle/Resources/views/content/tab/url/modal_add_custom_url.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/content/tab/url/modal_add_custom_url.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/content/tab/url/modal_add_custom_url.html.twig
Outdated
Show resolved
Hide resolved
Co-authored-by: DominikaK <[email protected]>
alongosz
requested changes
Oct 28, 2020
src/lib/Form/EventListener/AddSiteAccessFieldBasedOnContentListener.php
Outdated
Show resolved
Hide resolved
src/lib/Form/EventListener/AddSiteAccessFieldBasedOnContentListener.php
Outdated
Show resolved
Hide resolved
mikadamczyk
reviewed
Oct 29, 2020
src/lib/Form/EventListener/AddSiteAccessFieldBasedOnContentListener.php
Outdated
Show resolved
Hide resolved
src/lib/Form/EventListener/AddSiteAccessFieldBasedOnContentListener.php
Outdated
Show resolved
Hide resolved
alongosz
reviewed
Nov 2, 2020
src/lib/Tests/Form/Data/Content/CustomUrl/CustomUrlAddDataTest.php
Outdated
Show resolved
Hide resolved
Steveb-p
reviewed
Nov 2, 2020
ViniTou
approved these changes
Nov 6, 2020
webhdx
approved these changes
Nov 6, 2020
mikadamczyk
approved these changes
Nov 6, 2020
Member
Author
|
ping @ezsystems/documentation-team I think this functionality will benefit from some minor description somewhere (in doc or RN). |
dew326
reviewed
Nov 10, 2020
Co-authored-by: Dariusz Szut <[email protected]>
dew326
approved these changes
Nov 10, 2020
barw4
changed the title
micszo
approved these changes
Nov 12, 2020
Member
micszo
left a comment
micszo
left a comment
There was a problem hiding this comment.
Tested on eZ Platform EE 2.5 with branch.
Moving to Doc to cover the different combinations.
Member
|
Could yuo please merge up changes @barw4 ? |
Member
Author
|
There are issues with a multi repository setup. If you have the same location ids in both repositories the siteaccesschoicer will display all possible siteaccess even if they are stored in the other repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choice of Site Access has been added to the custom URL Alias form to help editors with providing a valid path when using
Place at site rootoption when certain Site Access has parametercontent.tree_root.location_iddefined.Checklist:
$ composer fix-cs)