Skip to content

Conversation

inigomarquinez
Copy link
Member

This PR migrates the CI pipeline from travis to GitHub actions and adds node version 11 to 22 to the matrix.

The travis project should be removed after merging the PR (see here).

The CI pipeline works in my local fork.

Related to jshttp/http-errors#108

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon UlisesGascon requested a review from LinusU May 14, 2024 16:37
Co-authored-by: Chris de Almeida <[email protected]>
@inigomarquinez inigomarquinez requested a review from ctcpip June 3, 2024 08:33
Copy link
Member

@ctcpip ctcpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json should not be added

@inigomarquinez inigomarquinez requested a review from ctcpip June 4, 2024 06:31
@inigomarquinez
Copy link
Member Author

@UlisesGascon , @ctcpip

Is this PR ready to be merged? Do you need me to do something else?

@ctcpip ctcpip merged commit c283061 into expressjs:master Jun 13, 2024
@inigomarquinez inigomarquinez deleted the ci/migrate-travis-to-gh-actions branch June 14, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants