Skip to content

Conversation

wesleytodd
Copy link
Member

Update setprototypeof. No impact here, but includes a fix for a possible prototype pollution in the fallback. Can be ported to 5.x as well.

@wesleytodd
Copy link
Member Author

To be very clear, this is not a security update. There are no uses of this module in express which allow for a prototype pollution. The update changes obj.hasOwnProperty(prop), which if used on untrusted user input can result in a prototype polution. Express does not use this module on untrusted user input.

@dougwilson dougwilson added the pr label Jan 28, 2020
@dougwilson dougwilson mentioned this pull request Feb 5, 2020
@dougwilson dougwilson added this to the 4.18 milestone Apr 23, 2020
@dougwilson dougwilson changed the base branch from master to 4.18 May 11, 2020 05:09
@dougwilson dougwilson mentioned this pull request May 20, 2020
20 tasks
@dougwilson dougwilson changed the base branch from 4.18 to master December 16, 2021 03:37
@dougwilson dougwilson force-pushed the update-setprototypeof branch from 14547eb to cbe25d6 Compare December 16, 2021 03:38
@dougwilson dougwilson merged commit cbe25d6 into expressjs:master Dec 16, 2021
nevilm-lt pushed a commit to nevilm-lt/express that referenced this pull request Mar 1, 2022
nevilm-lt pushed a commit to nevilm-lt/express that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants