Throw error if argument to res.status is null or undefined #2797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hope this gets merged, just ran into this issue yesterday! |
Contributor
|
Hi @jadengore , this is a breaking change and is tagged for the 5.x series. |
Contributor
|
Ah, yea, just looked at it and I see now. This is actually the third open PR to add this check. Maybe the other one has the code number check? |
Contributor
|
Sorry, my above comment was made in the wrong PR |
Contributor
|
If we're adding error checking here, is there a reason why we're not just enforcing an integer? If the change is breaking we might as well go all the way? EDIT: This pull request makes more sense by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2795 where res.status gives undescriptive error when the argument is null or undefined. I tested and all other inputs don't seem to have the same issue as null and undefined since they have .toString methods. I added unit tests to verify the new behaviour of res.status.
This is my first pull request on an open source project so if I formatted something wrong or went about submitting this wrong please let me know.