refactor: normalize common options for all parsers #551
Conversation
Phillip9587
force-pushed
the
normalize-options
branch
from
a03daf7 to
3f6cd01
Compare
|
@jonchurch I've made the requested changes. I think we should merge this first as foundational work for #22, so that when we start on it, the necessary changes are already in place and the scope remains smaller. Let me know what you think! |
Phillip9587
force-pushed
the
normalize-options
branch
3 times, most recently
from
ee6ba4c to
b760930
Compare
Phillip9587
force-pushed
the
normalize-options
branch
from
b760930 to
d93b76d
Compare
lib/utils.js
Outdated
| /*! | ||
| * body-parser | ||
| * Copyright(c) Express Contributors | ||
| * MIT Licensed | ||
| */ | ||
|
|
||
| 'use strict' |
There was a problem hiding this comment.
| /*! | |
| * body-parser | |
| * Copyright(c) Express Contributors | |
| * MIT Licensed | |
| */ | |
| 'use strict' | |
| 'use strict' |
files should not get copyright headers
|
Hey everyone, I just wanted to follow up on this PR and see if there's anything I can do to help move it forward. Let me know if any changes or additional context are needed! Thanks! |
|
Hey @jonchurch, thanks again for your review and approval a few weeks ago! I just wanted to check in and see if it’s all right to go ahead and merge this. Let me know if you have any additional concerns. |
|
Is this a semver minor, right? |
|
I would say it's a patch, this change doesn't introduce any new functionality, it just refactors it. |
|
@UlisesGascon Can we merge this now? |
|
I am checking with @wesleytodd... So far the plan is to include it in the next release (that will be shipped to in Express 5.1.0) :) |
|
@UlisesGascon Thanks! My work on #22 depends on this, so I'd really appreciate it if it could be merged soon. |
Based on #550
This PR introduces the
normalizeOptionsfunction, which standardizes and validates common parser options likeinflate,limit,type, andverify. It ensures consistent defaults and removes duplication across the parsers.